Add a mcp.json config and configuring mcp servers for GitHub Primer and Playwright#7694
Add a mcp.json config and configuring mcp servers for GitHub Primer and Playwright#7694
Conversation
jonrohan
added
skip changeset
|
There was a problem hiding this comment.
Pull request overview
Adds a VS Code MCP configuration to the repo to enable shared MCP server setup (GitHub Copilot MCP, Playwright MCP, and Primer MCP) as part of contributor dev experience, and updates gitignore so the config can be checked in.
Changes:
- Add
.vscode/mcp.jsondefining MCP servers forgithub,playwright, andprimer. - Stop ignoring
.vscodein.gitignoreso the MCP config (and other workspace configs) can be committed.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.vscode/mcp.json |
Introduces shared MCP server configuration for VS Code. |
.gitignore |
Removes .vscode from ignored paths to allow committing the MCP config. |
| "playwright": { | ||
| "command": "npx", | ||
| "args": [ | ||
| "-y", | ||
| "@microsoft/mcp-server-playwright" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
The playwright MCP server entry is missing a type field. Our own @primer/mcp README’s VS Code example config specifies type: "stdio" for command-based servers; without it, VS Code may not treat this server as a stdio MCP server and fail to start it. Add "type": "stdio" to the playwright server config for consistency and to match the documented schema.
| { | ||
| "servers": { | ||
| "github": { |
There was a problem hiding this comment.
The root MCP config omits the inputs field (the @primer/mcp README’s VS Code example includes "inputs": []). If VS Code expects this key (even as an empty array), the config may be considered incomplete or get rewritten by tooling. Consider adding "inputs": [] at the root for compatibility with the documented configuration shape.
Adding
.vscode/mcp.jsonconfig to the repository with playwright, github, and primer mcp servers configured.Rollout strategy
Merge checklist